-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To have attribute improvement + improved test coverage #454
To have attribute improvement + improved test coverage #454
Conversation
I'd only add tests and avoid refactoring of matchers. |
That is what I initially was doing I do agree, but in #438 I had noticed that there was an unexpected behaviour whereby if you pass in a non-string it previously would always succeed i.e this test would fail:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 👍
@mgrybyk good to merge from your side too?
@Harry-Liversedge thanks so much for this contribution! |
In support of #2 improving unit test coverage
closes #438