Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TS error in a test #271

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented Nov 9, 2020

fix this:

 FAIL  test/matchers/mock/toBeRequestedWith.test.ts
  ● Test suite failed to run
    src/matchers/mock/toBeRequestedWith.ts:29:37 - error TS2345: Argument of type 'string | Buffer | JsonObject | JsonArray' is not assignable to parameter of type 'string | jsonObject | jsonArray | undefined'.
      Type 'Buffer' is not assignable to type 'string | jsonObject | jsonArray | undefined'.
        Type 'Buffer' is not assignable to type 'jsonObject'.
          Index signature is missing in type 'Buffer'.
    29                         bodyMatcher(call.body, requestedWith.response)
                                           ~~~~~~~~~

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #271 (2a3abb5) into master (cb0db4b) will increase coverage by 6.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   68.02%   75.00%   +6.97%     
==========================================
  Files          40       40              
  Lines         860      860              
  Branches      209      209              
==========================================
+ Hits          585      645      +60     
+ Misses        258      202      -56     
+ Partials       17       13       -4     
Impacted Files Coverage Δ
src/matchers/mock/toBeRequestedWith.ts 98.48% <ø> (+35.60%) ⬆️
src/jasmineUtils.ts 66.39% <0.00%> (+10.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb0db4b...2a3abb5. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@christian-bromann christian-bromann merged commit b6f5452 into webdriverio:master Nov 9, 2020
@thorn0 thorn0 deleted the fix-a-test branch November 9, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants