Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on required webdriverio version #1635

Closed
zachlysobey opened this issue Aug 22, 2024 · 2 comments
Closed

Clarification on required webdriverio version #1635

zachlysobey opened this issue Aug 22, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@zachlysobey
Copy link
Contributor

zachlysobey commented Aug 22, 2024

In a project using this package, I've started getting install warnings saying "unmet peer webdriverio [...]".

it seems recent versions of this package have a peer dependency on an alpha v9 release of wdio.

  "peerDependencies": {
    "@wdio/globals": "^9.0.0-alpha.350",
    "@wdio/logger": "^9.0.0-alpha.350",
    "webdriverio": "^9.0.0-alpha.350"
  },

In the README however, it says:

NOTE: WebdriverIO v8.0.0 or higher is required!

Is the alpha peer dep a mistake? Or should the README be updated?

@zachlysobey zachlysobey changed the title Clarification on required webdriverio version. Clarification on required webdriverio version Aug 22, 2024
@christian-bromann
Copy link
Member

Is the alpha peer dep a mistake? Or should the README be updated?

The readme should be updated , mind taking a stab at this?

@christian-bromann christian-bromann added the help wanted Extra attention is needed label Aug 22, 2024
zachlysobey added a commit to zachlysobey/expect-webdriverio that referenced this issue Aug 27, 2024
@zachlysobey
Copy link
Contributor Author

Addressed via #1643

-NOTE: [WebdriverIO](https://github.com/webdriverio/webdriverio) `v8.0.0` or higher is required!
+NOTE: [WebdriverIO](https://github.com/webdriverio/webdriverio) `v9.0.0-alpha.350` or higher is required!

Lemme know if that looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants