Polyfill Element#matches.
#400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorvell
reviewed
Oct 20, 2020
|
|
||
| if (!Element_prototype.hasOwnProperty('matches')) { | ||
| Element_prototype.matches = | ||
| ((Element_prototype as any).webkitMatchesSelector as Element['matches']) ?? |
There was a problem hiding this comment.
Maybe add mozMatches (but not sure it's relevant at all)?
There was a problem hiding this comment.
Firefox 34 has the unprefixed version. I think the webkit... one might even be unnecessary now; the MDN page claims that these two should cover IE9+ though.
sorvell
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397. As mentioned in the bug,
Element#matchesexists with a vendor-prefixed in the browsers that we polyfill, so this just copies the function over using the standard name.