Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove function declarations from platform polyfills to sastisfy internal lint after import transforms. #396

Merged
merged 2 commits into from
Oct 17, 2020

Conversation

bicknellr
Copy link
Collaborator

During import, we're going to wrap these entire modules in if statements, but the internal linter doesn't like function declarations nested inside blocks that don't define the scope for the function's binding.

@bicknellr bicknellr requested a review from aomarks as a code owner October 16, 2020 23:56
@google-cla google-cla bot added the cla: yes label Oct 16, 2020
@bicknellr bicknellr merged commit 83aeb61 into master Oct 17, 2020
@bicknellr bicknellr deleted the remove-function-declarations branch October 17, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants