Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ added docker image with supervisord #6

Merged
merged 2 commits into from
Oct 31, 2020
Merged

+ added docker image with supervisord #6

merged 2 commits into from
Oct 31, 2020

Conversation

Surt
Copy link
Contributor

@Surt Surt commented Sep 6, 2020

The pulll request contains a folder docker with the most simple files to start nlpserver on a docker container.
It follows the laravel forge instructions and uses the official python:3.8.5-slim-buster base image.

I did not included the image since I think it's more transparent to build it yourself. Also, the language models are hardcoded.

NLP Server Docker image

Image creation

Inside the docker folder run

 docker build . --tag nlpserver:1.0

 docker run --publish 6400:6400 --detach --name nlpserver nlpserver:1.0  

For CoreNLP on another container run:

docker run -p 9000:9000 nlpbox/corenlp

@dugajean
Copy link

dugajean commented Oct 6, 2020

Good stuff dude, I was looking for this! I'll give it a try and submit a review here.

@web64
Copy link
Owner

web64 commented Oct 6, 2020

Thank you for submitting this PR!
I haven't had the chance to test this yet, so if @dugajean can test this and if it works ok I'm happy to merge this in.

@dugajean
Copy link

dugajean commented Oct 7, 2020

It fails here with an error:

polyglot download LANG:es

When removing this line and the next one the build passes. I'll keep testing.

@Surt
Copy link
Contributor Author

Surt commented Oct 14, 2020

It fails here with an error:

polyglot download LANG:es

When removing this line and the next one the build passes. I'll keep testing.

yes I lack the skill to make it cofigurable in some way so I add them in the build. Probaby there is better methods like using a custom docker .env etc

@pankajthekush
Copy link

pankajthekush commented Oct 19, 2020

I have created the docker Image,docker file and docker compose file , download these two files from this folder and run docker-compose up -d it will be up and running in a jiffy, supports only English langue for now but you don't have to worry about the dependency.

Edit: In the docker file please enter the main repo git link , I have put mine because I wanted to use the server suited for live run
in Dockerfile
instead of his RUN git clone https://github.com/pankajthekush/nlpserver.git
you can do
RUN git clone https://github.com/web64/nlpserver.git

If you don't make any changes it will still work.

Deleted "ES" languages.
@Surt
Copy link
Contributor Author

Surt commented Oct 20, 2020

Now it contains only EN. In any case anyone can edit the dockerfile to add more languages.

@web64 web64 merged commit dbf8714 into web64:master Oct 31, 2020
@web64
Copy link
Owner

web64 commented Oct 31, 2020

Thank you guys for your contribution!
We should try to find a way to make it easy to configure additional languages.
One of the goals of the NLP Server is to have multilingual support. For now, editing the dockerfile should be ok.

Cheers,
Olav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants