-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update gas estimation test #7074
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 18ae7ff | Previous: 51d216f | Ratio |
---|---|---|---|
processingTx |
8900 ops/sec (±5.17% ) |
9224 ops/sec (±3.84% ) |
1.04 |
processingContractDeploy |
39103 ops/sec (±8.96% ) |
41118 ops/sec (±7.75% ) |
1.05 |
processingContractMethodSend |
18797 ops/sec (±8.21% ) |
20556 ops/sec (±6.13% ) |
1.09 |
processingContractMethodCall |
37691 ops/sec (±6.31% ) |
41085 ops/sec (±4.96% ) |
1.09 |
abiEncode |
42988 ops/sec (±7.14% ) |
46586 ops/sec (±6.55% ) |
1.08 |
abiDecode |
28552 ops/sec (±8.76% ) |
31710 ops/sec (±6.85% ) |
1.11 |
sign |
1556 ops/sec (±0.92% ) |
1608 ops/sec (±0.76% ) |
1.03 |
verify |
357 ops/sec (±2.90% ) |
374 ops/sec (±2.89% ) |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
Description
#6234
Wasn't able to reproduce gas estimation error, but was able to fix another issue with serializing bigInt.
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.