Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove non read-only ens methods #6084

Merged
merged 14 commits into from
May 30, 2023
Merged

fix!: remove non read-only ens methods #6084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1ffc70f
fix!: remove non read-only ens methods
mpetrunic May 12, 2023
1f865ad
fix integration tests
mpetrunic May 15, 2023
7025b01
Merge branch '4.x' into fix!--remove-extra-ens-methods
mpetrunic May 15, 2023
93d8602
Merge branch '4.x' into fix!--remove-extra-ens-methods
jdevcs May 19, 2023
2f380e6
Merge branch '4.x' into fix!--remove-extra-ens-methods
avkos May 24, 2023
d9decfb
fix tests
avkos May 24, 2023
afc7866
Merge branch '4.x' into fix!--remove-extra-ens-methods
nikoulai May 25, 2023
47a7f60
fix tests
avkos May 25, 2023
069ae4f
remove unnecessary tests
avkos May 25, 2023
7253932
increase coverage
avkos May 25, 2023
642ac04
Merge branch '4.x' into fix!--remove-extra-ens-methods
avkos May 25, 2023
a442eaf
fix changelog
avkos May 25, 2023
55deadf
skip internal provider test for now
avkos May 25, 2023
c47f89e
Merge branch '4.x' into fix!--remove-extra-ens-methods
May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,6 +1465,7 @@ should use 4.0.1-alpha.0 for testing.
### Breaking Changes

- dropped support for NodeJs@14
- removed non read-only methods from ens package

### Added

Expand Down
4 changes: 4 additions & 0 deletions packages/web3-eth-ens/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Bug fix of `checkNetwork` in ENS (#5988)

## [Unreleased]

### Removed

- Removed non read-only methods (#6084)
211 changes: 0 additions & 211 deletions packages/web3-eth-ens/src/abi/ens/ENSRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,36 +17,6 @@ along with web3.js. If not, see <http://www.gnu.org/licenses/>.

// https://github.com/ensdomains/ens-contracts/blob/master/contracts/registry/ENSRegistry.sol
export const ENSRegistryAbi = [
{
inputs: [],
stateMutability: 'nonpayable',
type: 'constructor',
},
{
anonymous: false,
inputs: [
{
indexed: true,
internalType: 'address',
name: 'owner',
type: 'address',
},
{
indexed: true,
internalType: 'address',
name: 'operator',
type: 'address',
},
{
indexed: false,
internalType: 'bool',
name: 'approved',
type: 'bool',
},
],
name: 'ApprovalForAll',
type: 'event',
},
{
anonymous: false,
inputs: [
Expand Down Expand Up @@ -91,25 +61,6 @@ export const ENSRegistryAbi = [
name: 'NewResolver',
type: 'event',
},
{
anonymous: false,
inputs: [
{
indexed: true,
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
indexed: false,
internalType: 'uint64',
name: 'ttl',
type: 'uint64',
},
],
name: 'NewTTL',
type: 'event',
},
{
anonymous: false,
inputs: [
Expand Down Expand Up @@ -210,168 +161,6 @@ export const ENSRegistryAbi = [
stateMutability: 'view',
type: 'function',
},
{
inputs: [
{
internalType: 'address',
name: 'operator',
type: 'address',
},
{
internalType: 'bool',
name: 'approved',
type: 'bool',
},
],
name: 'setApprovalForAll',
outputs: [],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
internalType: 'address',
name: 'owner',
type: 'address',
},
],
name: 'setOwner',
outputs: [],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
internalType: 'address',
name: 'owner',
type: 'address',
},
{
internalType: 'address',
name: 'resolver',
type: 'address',
},
{
internalType: 'uint64',
name: 'ttl',
type: 'uint64',
},
],
name: 'setRecord',
outputs: [],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
internalType: 'address',
name: 'resolver',
type: 'address',
},
],
name: 'setResolver',
outputs: [],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
internalType: 'bytes32',
name: 'label',
type: 'bytes32',
},
{
internalType: 'address',
name: 'owner',
type: 'address',
},
],
name: 'setSubnodeOwner',
outputs: [
{
internalType: 'bytes32',
name: '',
type: 'bytes32',
},
],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
internalType: 'bytes32',
name: 'label',
type: 'bytes32',
},
{
internalType: 'address',
name: 'owner',
type: 'address',
},
{
internalType: 'address',
name: 'resolver',
type: 'address',
},
{
internalType: 'uint64',
name: 'ttl',
type: 'uint64',
},
],
name: 'setSubnodeRecord',
outputs: [],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
internalType: 'bytes32',
name: 'node',
type: 'bytes32',
},
{
internalType: 'uint64',
name: 'ttl',
type: 'uint64',
},
],
name: 'setTTL',
outputs: [],
stateMutability: 'nonpayable',
type: 'function',
},
{
inputs: [
{
Expand Down
Loading