Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handle of the revert raison of a call (issue #4454) #5962

Closed
wants to merge 7 commits into from
Closed

better handle of the revert raison of a call (issue #4454) #5962

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5e2cc19
improvement of 'web3-core-method.buildCall.sendTxCallback(err, result…
nicos99 Mar 26, 2023
687b8d6
continuation of previous work on 'web3-core-method.buildCall.sendTxCa…
nicos99 Mar 26, 2023
6e9dce5
add fixed #4454 in the CHANGELOG
nicos99 Mar 27, 2023
964577c
Merge 1.x into manage-revert-call-from-metamask
nicos99 Apr 4, 2023
7464687
add unit test to cover my improvement of 'web3-core-method.buildCall.…
nicos99 Apr 7, 2023
2877e11
removal of unnecessary debug logs
nicos99 Apr 10, 2023
fd28ba8
Merge remote-tracking branch 'remotes/origin/develop' into manage-rev…
nicos99 Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,3 +662,7 @@ Released with 1.0.0-beta.37 code base.
- Updated dependencies (#5885)

## [Unreleased]

### Fixed

- Fixed "Uncaught TypeError" calling a contract function that revert using MetaMask (#4454)
10 changes: 9 additions & 1 deletion packages/web3-core-method/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,15 @@ Method.prototype.buildCall = function () {
if (!err && method.isRevertReasonString(result)){
reasonData = result.substring(10);
} else if (err && err.data){
reasonData = err.data.substring(10);
// workaround embedded error details got from some providers like MetaMask
if (typeof err.data === 'object') {
// Ganache has no `originalError` sub-object unlike others
var originalError = err.data.originalError ?? err.data;
reasonData = originalError.data.substring(10);
}
else {
reasonData = err.data.substring(10);
}
}

if (reasonData){
Expand Down