-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types for user input in send/call #5960
Merged
Merged
Changes from 33 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
29a3e12
Add types for user input in send/call
nikoulai 93f05cf
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
nikoulai 021f6de
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
spacesailor24 e65fc1b
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
Muhammad-Altabba 45591ea
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
Muhammad-Altabba 205d4ac
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
nikoulai 061bf24
Revert types
nikoulai f817f32
remove chainId, to, data & input from NonPayableCallOptions
nikoulai c78160d
Merge branch 'nikos/5945/inocrrect-type-for-options' of https://githu…
nikoulai ad0dcb3
Remove input from deployOptions
nikoulai 0d30e8b
Fix createAccessListType
nikoulai 180761a
Fix createAccessListType payable and estimateGas
nikoulai 3505d9b
Fix send and call
nikoulai 4f0e50a
Modify test
nikoulai 488e9c5
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
nikoulai 971e0f5
Remove unused types from NonPayableCallOptions
nikoulai 87c4b30
Allow type in estimateGas
nikoulai 675cd00
Revert deploy test
nikoulai 6f0aa73
Fix contract test
nikoulai b1ae75d
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
avkos e43d526
Apply changes to docs
nikoulai 7fb6fa8
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
jdevcs c1372dc
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
nikoulai 53355bb
Delete properties again after merge
nikoulai c051bc0
Merge branch 'nikos/5945/inocrrect-type-for-options' of https://githu…
nikoulai b7cb424
Update changelog
nikoulai 234501f
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
nikoulai 3b7e8c1
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
nikoulai 9f0a760
Address feedback for types
nikoulai 71ac77e
Undo delete to property
nikoulai 88c956c
Allow input for contract deployment
nikoulai e24754a
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
nikoulai b44d5dc
Remove delete to
nikoulai f8004c0
Fix types
nikoulai 7240e5c
Address feedback
nikoulai a243767
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
nikoulai 33ddd5f
Remove unecessary file
nikoulai 0697462
Merge branch 'nikos/5945/inocrrect-type-for-options' of https://githu…
nikoulai f6e0fa0
Merge branch '4.x' into nikos/5945/inocrrect-type-for-options
spacesailor24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
input
is the correct term