Use MaxAttemptsReachedOnReconnectingError similar to v1.x
#5894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…connection + rename `_providerOptions` to `_socketOptions`
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed No assets were removed Bigger
Smaller
Unchanged
|
Deploying with
|
| Latest commit: |
84029a2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d106f270.web3-js-docs.pages.dev |
| Branch Preview URL: | https://feature-5889-keep-emitting-t.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #5894 +/- ##
==========================================
+ Coverage 80.85% 80.86% +0.01%
==========================================
Files 136 136
Lines 5901 5900 -1
Branches 1537 1537
==========================================
Hits 4771 4771
+ Misses 1130 1129 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ot-passed-to-the-constructor-of-the-underlying-socket-object' into feature/5889/keep-emitting-the-error-as-an-object-for-maximum-number-of-reconnect-attempts-reached
11e454f to
9e1d763
Compare
MaxAttemptsReachedOnReconnectingError similar to v1.xMaxAttemptsReachedOnReconnectingError similar to v1.x
MaxAttemptsReachedOnReconnectingError similar to v1.xMaxAttemptsReachedOnReconnectingError similar to v1.x
…ject-for-maximum-number-of-reconnect-attempts-reached
31 tasks
…aximum-number-of-reconnect-attempts-reached' of https://github.com/ChainSafe/web3.js into feature/5889/keep-emitting-the-error-as-an-object-for-maximum-number-of-reconnect-attempts-reached
88205fc to
bc74b2b
Compare
luu-alex
reviewed
Mar 9, 2023
| const errorMsg = `Max connection attempts exceeded (${this._reconnectOptions.maxAttempts})`; | ||
| this._eventEmitter.emit('error', errorMsg); | ||
| this._eventEmitter.emit( | ||
| 'error', |
There was a problem hiding this comment.
https://github.com/web3/web3.js/runs/11848321915 codecov seems to be failing, otherwise PR LGTM
There was a problem hiding this comment.
Thanks @luu-alex ,
Actually, this is tested twice inside web3-providers-ws and web3-providers-ipc. But CodeCov does not check across packages. So, I think it is safe to ignore it. Or what do you think?
There was a problem hiding this comment.
couldn't we have a dedicated test in web3-utils for that?
There was a problem hiding this comment.
Actually, we can. But it will require a complex scenario that is already tested twice with IpcProvider and WebSocketProvider. So, writing the test will be just time-consuming, I think 😊 .
There was a problem hiding this comment.
Actually, this is tested twice inside web3-providers-ws and web3-providers-ipc. But CodeCov does not check across packages
currently codecov is only checking unit-testing inside packages and not counting any coverage for tests across packages ( integration tests )
…ject-for-maximum-number-of-reconnect-attempts-reached
nikoulai
approved these changes
Mar 9, 2023
| const errorMsg = `Max connection attempts exceeded (${this._reconnectOptions.maxAttempts})`; | ||
| this._eventEmitter.emit('error', errorMsg); | ||
| this._eventEmitter.emit( | ||
| 'error', |
There was a problem hiding this comment.
couldn't we have a dedicated test in web3-utils for that?
…ject-for-maximum-number-of-reconnect-attempts-reached
jdevcs
reviewed
Mar 9, 2023
jdevcs
approved these changes
Mar 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5889
Type of change
Checklist for 1.x:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.Checklist for 4.x:
yarnsuccessfullyyarn lintsuccessfullyyarn build:websuccessfullyyarn test:unitsuccessfullyyarn test:integrationsuccessfullycompile:contractssuccessfullyCHANGELOG.mdfile in the packages I have edited.