-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional param hex
to getTransaction
and getBlock
.
#5845
Add optional param hex
to getTransaction
and getBlock
.
#5845
Conversation
+ add helpful exception for wrong inputs + fix some test case.
Pull Request Test Coverage Report for Build 4230254163Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build files indist
should be removed, as these are only included in release PR.
…ttps://github.com/ChainSafe/web3.js into fix/5761/enable-hexToNumber-to-handle-large-numbers
hexToNumber
to return big numbers as stringshex
for getTransaction
and getBlock
.
hex
for getTransaction
and getBlock
.hex
to getTransaction
and getBlock
.
Thanks for this change Muhammad, it looks good. One thing can you update the documentation too, https://web3js.readthedocs.io/en/v1.8.2/web3-utils.html#hextonumber |
…ttps://github.com/ChainSafe/web3.js into fix/5761/enable-hexToNumber-to-handle-large-numbers
Description
Fixes #5761 and #5703 by adding an optional parameter
hex
for bothgetTransaction
andgetBlock
.However, another optional
bigIntOnOverflow
has been added athexToNumber
andtoNumber
only. Which introduces a functionality similar to 4.x for those 2 functions only.Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.