Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5634/alex fix inconsistent event emitter geth ipc tests #5822

Closed
wants to merge 29 commits into from
Closed

5634/alex fix inconsistent event emitter geth ipc tests #5822

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
c99d7f2
adding consolelogs
Feb 8, 2023
8fb04f4
update to debug
Feb 8, 2023
ca05bff
remove debug logs
Feb 8, 2023
1736777
update changelog
Feb 9, 2023
81f8b76
Merge branch '4.x' into 5634/alex
Feb 9, 2023
c890db9
format and spelling fixes
Feb 9, 2023
26124f2
Merge branch '4.x' into 5634/alex
Feb 13, 2023
59da4f6
adding mine to echo
Feb 13, 2023
4779a5f
Merge branch '4.x' into 5634/alex
jdevcs Feb 14, 2023
480bb95
Merge branch '4.x' into 5634/alex
Feb 14, 2023
ec8e2f1
Merge branch '4.x' into 5634/alex
Feb 21, 2023
cd726d6
remove mine flag
Feb 21, 2023
86ee31e
fix disconnect function
avkos Feb 22, 2023
8cdb6f7
add link
avkos Feb 23, 2023
5fb3c81
test types
avkos Feb 23, 2023
bccda0e
add disconnect function test
avkos Feb 23, 2023
f55b123
fix eth tests
avkos Feb 23, 2023
f96118a
use dev period
Feb 24, 2023
9a3bed1
test stuck
avkos Feb 24, 2023
00e6026
trace
avkos Feb 24, 2023
fed2aab
fix
avkos Feb 24, 2023
a5d9e6f
check
avkos Feb 24, 2023
4713128
fix test
avkos Feb 24, 2023
73134b2
add empty disconnect function
avkos Feb 24, 2023
18d1c1f
update mine
Feb 24, 2023
b4f9b52
Merge branch 'ok/5864-Disconnect-function-doesn't-exists-in-types-of-…
Feb 24, 2023
30a75a4
Merge branch '4.x' into 5634/alex
Feb 26, 2023
c93802d
add back mine
Feb 26, 2023
3aa5fe3
Revert "Merge branch 'ok/5864-Disconnect-function-doesn't-exists-in-t…
Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/web3-eth-contract/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ const transactionHash = receipt.transactionHash;

### Fixed

- Fix contract defaults (#5756)
- Fixed contract defaults (#5756)
- Fixed getPastEvents Error (#5819)

### Changed

Expand Down
8 changes: 4 additions & 4 deletions scripts/geth_binary.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ start() {
download
if [ -z "${ORIGARGS[1]}" ]; then
echo "Starting geth..."
echo "geth --ipcpath $IPC_PATH --nodiscover --nousb --ws --ws.addr 0.0.0.0 --ws.port $WEB3_SYSTEM_TEST_PORT --http --http.addr 0.0.0.0 --http.port $WEB3_SYSTEM_TEST_PORT --allow-insecure-unlock --http.api personal,web3,eth,admin,debug,txpool,net --ws.api personal,web3,eth,admin,debug,miner,txpool,net --dev --dev.period=0 "
${TMP_FOLDER}/geth --ipcpath $IPC_PATH --nodiscover --nousb --ws --ws.addr 0.0.0.0 --ws.port $WEB3_SYSTEM_TEST_PORT --http --http.addr 0.0.0.0 --http.port $WEB3_SYSTEM_TEST_PORT --allow-insecure-unlock --http.api personal,web3,eth,admin,debug,txpool,net --ws.api personal,web3,eth,admin,debug,miner,txpool,net --dev --dev.period=0
echo "geth --ipcpath $IPC_PATH --nodiscover --nousb --ws --ws.addr 0.0.0.0 --ws.port $WEB3_SYSTEM_TEST_PORT --http --http.addr 0.0.0.0 --http.port $WEB3_SYSTEM_TEST_PORT --allow-insecure-unlock --http.api personal,web3,eth,admin,debug,txpool,net --ws.api personal,web3,eth,admin,debug,miner,txpool,net --dev --mine --dev.period=0 "
${TMP_FOLDER}/geth --ipcpath $IPC_PATH --nodiscover --nousb --ws --ws.addr 0.0.0.0 --ws.port $WEB3_SYSTEM_TEST_PORT --http --http.addr 0.0.0.0 --http.port $WEB3_SYSTEM_TEST_PORT --allow-insecure-unlock --http.api personal,web3,eth,admin,debug,txpool,net --ws.api personal,web3,eth,admin,debug,miner,txpool,net --dev --mine --dev.period=0
else
echo "Starting geth..."
echo "geth --ipcpath $IPC_PATH --nodiscover --nousb --ws --ws.addr 0.0.0.0 --ws.port $WEB3_SYSTEM_TEST_PORT --http --http.addr 0.0.0.0 --http.port $WEB3_SYSTEM_TEST_PORT --allow-insecure-unlock --http.api personal,web3,eth,admin,debug,txpool,net --ws.api personal,web3,eth,admin,debug,miner,txpool,net --dev --dev.period=0 &>/dev/null &"
${TMP_FOLDER}/geth --ipcpath $IPC_PATH --nodiscover --nousb --ws --ws.addr 0.0.0.0 --ws.port $WEB3_SYSTEM_TEST_PORT --http --http.addr 0.0.0.0 --http.port $WEB3_SYSTEM_TEST_PORT --allow-insecure-unlock --http.api personal,web3,eth,admin,debug,txpool,net --ws.api personal,web3,eth,admin,debug,miner,txpool,net --dev --dev.period=0 &>/dev/null &
echo "geth --ipcpath $IPC_PATH --nodiscover --nousb --ws --ws.addr 0.0.0.0 --ws.port $WEB3_SYSTEM_TEST_PORT --http --http.addr 0.0.0.0 --http.port $WEB3_SYSTEM_TEST_PORT --allow-insecure-unlock --http.api personal,web3,eth,admin,debug,txpool,net --ws.api personal,web3,eth,admin,debug,miner,txpool,net --dev --mine --dev.period=0 &>/dev/null &"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have insta blocks mining for existing 4.x testing and blocks were created without this flag.
adding mine flag, geth will activate POW algo and do CPU mining. For issue under investigation #5634 the problem was transactions were not mined or new blocks were not created?

${TMP_FOLDER}/geth --ipcpath $IPC_PATH --nodiscover --nousb --ws --ws.addr 0.0.0.0 --ws.port $WEB3_SYSTEM_TEST_PORT --http --http.addr 0.0.0.0 --http.port $WEB3_SYSTEM_TEST_PORT --allow-insecure-unlock --http.api personal,web3,eth,admin,debug,txpool,net --ws.api personal,web3,eth,admin,debug,miner,txpool,net --dev --mine --dev.period=0 &>/dev/null &
echo "Waiting for geth..."
npx wait-port -t 10000 "$WEB3_SYSTEM_TEST_PORT"
fi
Expand Down