5704 memory leak in web3.eth.contract #5792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
c6026b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://649e9e5c.web3-js-docs.pages.dev |
| Branch Preview URL: | https://ok-5704-memory-leak-in-web3-.web3-js-docs.pages.dev |
jdevcs
reviewed
Jan 31, 2023
| @@ -91,16 +88,6 @@ export class Web3 extends Web3Context<EthExecutionAPI> { | |||
| } else { | |||
| super(jsonInterface, self.getContextObject()); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Also update change log for this.
jdevcs
approved these changes
Jan 31, 2023
luu-alex
reviewed
Jan 31, 2023
CHANGELOG.md
Outdated
|
|
||
| ##### Removed | ||
|
|
||
| - Private static `_contracts:Contract[]` and static `setProvider` function was removed |
luu-alex
approved these changes
Jan 31, 2023
nikoulai
approved these changes
Jan 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5704
So the problem was a new
SubscriptionManagerwhich was created every time when making a new instance of the Contract class because, by default, web3 didn't create theregisteredSubscriptionsobject. So I've added the object by default. And now it always reuses the sameSubscriptionManagerin the contract class.Also, I've removed the array of contracts in the web3 package. Because we don't need it. When we set the provider in one of the contracts or in web3, it affects all instances.
After these changes memory leak disappears.
Type of change
Checklist for 4.x:
yarnsuccessfullyyarn lintsuccessfullyyarn build:websuccessfullyyarn test:unitsuccessfullyyarn test:integrationsuccessfullycompile:contractssuccessfullyCHANGELOG.mdfile in the packages I have edited.