Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node minimum version to 14 #5765

Merged
merged 6 commits into from
Jan 26, 2023

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Fixes #5391

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

@Muhammad-Altabba Muhammad-Altabba added the 4.x 4.0 related label Jan 18, 2023
@github-actions github-actions bot temporarily deployed to Preview: (feature/5391/update-node-minimum-version-to-14) January 18, 2023 16:55 Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d2fa9b2
Status: ✅  Deploy successful!
Preview URL: https://bc929d6e.web3-js-docs.pages.dev
Branch Preview URL: https://feature-5391-update-node-min.web3-js-docs.pages.dev

View logs

@github-actions github-actions bot temporarily deployed to Preview: (feature/5391/update-node-minimum-version-to-14) January 18, 2023 16:55 Inactive
@@ -5,7 +5,7 @@
"main": "lib/index.js",
"repository": "https://github.com/ChainSafe/web3.js",
"engines": {
"node": ">=12.0.0"
"node": ">=14.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some packages have an npm min version, and some - not. I think it will be great to have the same config in all packages. Also, maybe we should add engine config to all packages. What do you think?

"engines": {
		"node": ">=14",
		"npm": ">=6.12.0"
	},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good suggestion to me.

@github-actions github-actions bot temporarily deployed to Preview: (feature/5391/update-node-minimum-version-to-14) January 19, 2023 09:49 Inactive
@github-actions github-actions bot temporarily deployed to Preview: (feature/5391/update-node-minimum-version-to-14) January 19, 2023 09:50 Inactive
@github-actions github-actions bot temporarily deployed to Preview: (feature/5391/update-node-minimum-version-to-14) January 22, 2023 10:23 Inactive
@github-actions github-actions bot temporarily deployed to Preview: (feature/5391/update-node-minimum-version-to-14) January 24, 2023 14:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants