-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node minimum version to 14 #5765
Update node minimum version to 14 #5765
Conversation
Deploying with
|
Latest commit: |
d2fa9b2
|
Status: | ✅ Deploy successful! |
Preview URL: | https://bc929d6e.web3-js-docs.pages.dev |
Branch Preview URL: | https://feature-5391-update-node-min.web3-js-docs.pages.dev |
packages/web3/package.json
Outdated
@@ -5,7 +5,7 @@ | |||
"main": "lib/index.js", | |||
"repository": "https://github.com/ChainSafe/web3.js", | |||
"engines": { | |||
"node": ">=12.0.0" | |||
"node": ">=14.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some packages have an npm min version, and some - not. I think it will be great to have the same config in all packages. Also, maybe we should add engine config to all packages. What do you think?
"engines": {
"node": ">=14",
"npm": ">=6.12.0"
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good suggestion to me.
Description
Fixes #5391
Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.