Nikos/5096/improve the integration test for contracts default attributes #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontracts-default-attributes
jdevcs
requested changes
Nov 7, 2022
|
|
||
| Contract.defaultHardfork = hardfork; | ||
|
|
||
| contract = await contract.deploy(deployOptions).send(sendOptions); |
There was a problem hiding this comment.
Tx passed to
should also be checked for hardfork valueThere was a problem hiding this comment.
For failing tests could you add skip to test and create a new issue for bug investigation.
There was a problem hiding this comment.
Just opened one
#5603
packages/web3-eth-contract/test/integration/contract_defaults_extra.test.ts
Show resolved
Hide resolved
|
Good work |
|
Your Render PR Server URL is https://atweb3js-docs-pr-5585.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cdkfl5aen0hgihd43lfg. |
…ontracts-default-attributes
803108a to
1320536
Compare
1320536 to
f6a1bb8
Compare
1d5e972 to
766190d
Compare
luu-alex
reviewed
Nov 8, 2022
jdevcs
approved these changes
Nov 10, 2022
luu-alex
approved these changes
Nov 10, 2022
avkos
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5096
Checklist for 4.x:
yarnsuccessfullyyarn lintsuccessfullyyarn build:websuccessfullyyarn test:unitsuccessfullyyarn test:integrationsuccessfullycompile:contractssuccessfullyCHANGELOG.mdfile in the packages I have edited.