Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Subscription functions #4895

Merged
merged 33 commits into from
Apr 19, 2022
Merged

move Subscription functions #4895

merged 33 commits into from
Apr 19, 2022

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Mar 28, 2022

Description

4830

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@avkos avkos added the 4.x 4.0 related label Mar 28, 2022
@avkos avkos marked this pull request as ready for review March 29, 2022 15:53
@avkos
Copy link
Contributor Author

avkos commented Mar 29, 2022

change name of subscriptions related to this doc https://geth.ethereum.org/docs/rpc/pubsub :
pendingTransactions => newPendingTransactions
newBlockHeaders => newHeads

@avkos avkos requested review from jdevcs and nazarhussain April 10, 2022 18:03
avkos added 4 commits April 11, 2022 11:47
…scribe

# Conflicts:
#	packages/web3-core/src/web3_context.ts
#	packages/web3-eth/src/web3_eth.ts
@avkos avkos requested a review from nazarhussain April 14, 2022 14:08
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
@avkos avkos merged commit e5f76aa into 4.x Apr 19, 2022
@avkos avkos deleted the task/4830_web3.eth.subscribe branch April 19, 2022 13:12
@nikoulai nikoulai restored the task/4830_web3.eth.subscribe branch April 19, 2022 14:24
@nikoulai nikoulai deleted the task/4830_web3.eth.subscribe branch April 19, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants