Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init feature_request template - Closes #4367 #4370

Merged
merged 9 commits into from
Sep 29, 2021
Merged

Init feature_request template - Closes #4367 #4370

merged 9 commits into from
Sep 29, 2021

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Sep 24, 2021 •
edited
Loading

@spacesailor24 spacesailor24 added Enhancement Includes improvements or optimizations 1.x 1.0 related issues 4.x 4.0 related labels Sep 24, 2021
@spacesailor24 spacesailor24 self-assigned this Sep 24, 2021
@render
Copy link

render bot commented Sep 24, 2021

Your Render PR Server URL is https://web3-js-pr-4370.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c56k9lpt9dsc3cro0fdg.

@coveralls
Copy link

coveralls commented Sep 24, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1285014695

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 427 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.3%) to 72.545%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/src/formatters.js 23 81.4%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 92 12.86%
packages/web3-eth-accounts/src/index.js 163 23.77%
Totals Coverage Status
Change from base Build 1285014022: -2.3%
Covered Lines: 3355
Relevant Lines: 4367
💛 - Coveralls

@spacesailor24 spacesailor24 merged commit 44bb68a into 1.x Sep 29, 2021
@spacesailor24 spacesailor24 deleted the wyatt/4367-feature-request-template branch September 29, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarhussain nazarhussain nazarhussain approved these changes

@philknows philknows philknows approved these changes

@jdevcs jdevcs jdevcs approved these changes

@luu-alex luu-alex Awaiting requested review from luu-alex

Assignees

@spacesailor24 spacesailor24

Labels
1.x 1.0 related issues 4.x 4.0 related Enhancement Includes improvements or optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request
5 participants
@spacesailor24 @coveralls @nazarhussain @philknows @jdevcs