-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing promievent handlers - closes #4194 #4336
Conversation
Your Render PR Server URL is https://web3-js-pr-4336.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c54foek6fj35rk7l17qg. |
Pull Request Test Coverage Report for Build 1291773462
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, only one change required in changelog:
- Added missing PromiEvent handler types (#4194)
be under :
## [Unreleased]
## [1.5.4]
### Changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from @jdevcs comment LGTM
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.