Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing promievent handlers - closes #4194 #4336

Merged
merged 11 commits into from
Sep 30, 2021
Merged

add missing promievent handlers - closes #4194 #4336

merged 11 commits into from
Sep 30, 2021

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Sep 20, 2021

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@render
Copy link

render bot commented Sep 20, 2021

@coveralls
Copy link

coveralls commented Sep 23, 2021

Pull Request Test Coverage Report for Build 1291773462

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 264 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.3%) to 74.836%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 6 84.87%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-utils/src/utils.js 44 9.66%
packages/web3-eth-accounts/src/index.js 107 23.67%
Totals Coverage Status
Change from base Build 1285611257: 2.3%
Covered Lines: 3224
Relevant Lines: 4073

💛 - Coveralls

@luu-alex luu-alex marked this pull request as ready for review September 23, 2021 13:21
@luu-alex luu-alex changed the title add missing promievent - closes #4194 add missing promievent handlers - closes #4194 Sep 23, 2021
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only one change required in changelog:
- Added missing PromiEvent handler types (#4194) be under :

## [Unreleased]

## [1.5.4]

### Changed

nazarhussain
nazarhussain previously approved these changes Sep 24, 2021
Copy link
Contributor

@nazarhussain nazarhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from @jdevcs comment LGTM

@luu-alex luu-alex merged commit d4155d6 into 1.x Sep 30, 2021
@luu-alex luu-alex deleted the alex/4194 branch September 30, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants