Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account.hashMessage with non-ASCII characters #3526

Merged
merged 3 commits into from
May 22, 2020
Merged

Fix account.hashMessage with non-ASCII characters #3526

merged 3 commits into from
May 22, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented May 19, 2020

Description

This PR aims to fix #3523 where hashing a message with non-ASCII characters should work.

The first commit adds a failing test, and the second commit fixes the hashMessage method by handling conversion of utf8 data.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@ryanio ryanio added 1.x 1.0 related issues Bug Addressing a bug labels May 19, 2020
@coveralls
Copy link

coveralls commented May 19, 2020

Coverage Status

Coverage increased (+0.003%) to 89.622% when pulling 077e416 on issue/3523 into 5a09ca0 on 1.x.

@cgewecke cgewecke self-requested a review May 19, 2020 18:04
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Looks good 💯

@cgewecke cgewecke merged commit 53e4cab into 1.x May 22, 2020
@cgewecke cgewecke deleted the issue/3523 branch May 22, 2020 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

account.hashMessage is incorrect with non-ASCII characters
3 participants