-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ABICoder dependency #3490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6f45a3
to
8bfd4c3
Compare
8bfd4c3
to
64ddf0f
Compare
b2b11b3
to
4b08c04
Compare
13 tasks
5bc42c5
to
c9260ca
Compare
Couple notes: @ryanio Is is correct that there's an upstream fix pending for the last remaining failure in the It has a message like:
Cause is web3-eth-abi called directly with a payload that looks like this: web3.eth.abi.encodeParameters(
[
'bytes32',
'uint256',
'bytes32',
'address[] memory', // Ethers V5 doesn't like this 'memory' keyword
'uint256[] memory',
'uint256',
],
[
KERNEL_TYPEHASH,
height.toNumber(),
parent,
updatedValidators,
updatedReputation,
gasTarget.toNumber(),
],
) Apart from that this PR LGTM and is a huge step forward 💯 💯 |
cgewecke
previously approved these changes
May 6, 2020
cgewecke
approved these changes
May 7, 2020
This was referenced May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to resolve #3484 by updating the
web3-eth-abi
'sethers
dep to@ethersproject/abi
.To maintain existing functionality, these cases were added to
encodeParameters
:bytes
to make them even.bytes32
to make them fixed.bytes
andbytes32
rules above.bytes32
nested inside atuple
.Buffer
input valueType of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases do cover all lines and branches of the added code.npm run build-all
and tested the resulting file/'s fromdist
folder in a browser.CHANGELOG.md
file in the root folder.