fixed Web3Utils toHex() for Buffer input #3021 #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivida
suggested changes
Sep 29, 2019
nivida
suggested changes
Oct 13, 2019
nivida
reviewed
Oct 13, 2019
Co-Authored-By: Samuel Furter <nivida@users.noreply.github.com>
nivida
approved these changes
Oct 14, 2019
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* fixed Web3Utils toHex for Buffer input web3#3021 * updated toHex funcDoc and CHANGELOG.md * used toString instead of bytesToHex * updated packages/web3-utils/src/utils.js Co-Authored-By: Samuel Furter <nivida@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in response to #3021