Fix unreliable array test in Contract package #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using node.js 6.11.2 I get the following error when trying to instantiate contracts: > jsonInterface instanceof Array true > new web3.eth.Contract(jsonInterface) Error: You must provide the json interface of the contract when instatiating a contract object. Although jsonInterface instanceof Array evaluates to true, the exact same test condition evaluates to false within the Contract constructor with the passed down json interface. Using either "Array.isArray(jsonInterface)" or "toString.call(jsonInterface) === '[object Array]'" as a test condition instead fixes the issue. Also the typo in the error message got corrected.
|
Thanks for the find! |
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
Using node.js 6.11.2 I get the following error when trying to instantiate contracts: > jsonInterface instanceof Array true > new web3.eth.Contract(jsonInterface) Error: You must provide the json interface of the contract when instatiating a contract object. Although jsonInterface instanceof Array evaluates to true, the exact same test condition evaluates to false within the Contract constructor with the passed down json interface. Using either "Array.isArray(jsonInterface)" or "toString.call(jsonInterface) === '[object Array]'" as a test condition instead fixes the issue. Also the typo in the error message got corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using node.js 6.11.2 I get the following error when trying to instantiate contracts:
Although
jsonInterface instanceof Arrayevaluates to true, the exact same test condition evaluates to false within the Contract constructor with the passed down json interface. Using eitherArray.isArray(jsonInterface)ortoString.call(jsonInterface) === '[object Array]'as a test condition instead fixes the issue.Also the typo in the error message got corrected.