chore: use staging pickup in staging cron-pins job #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change cron-pins ci workflow to use staging pickup for the staging run and prod for prod. - uses `includes` to add `pickup_url` per env. see: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurations - we can't use github environments here as you can only have 1 of those set on the job, you can't use them in a matrix. Previously we used the same cluster url for both. We now want to see staging traffic hitting staging pickup. Also cleans out some unused old cluster vars. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
alanshaw
approved these changes
Jan 13, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change cron-pins ci workflow to use staging pickup for the staging run and prod for prod.
includesto addpickup_urlper env. see: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurationsPreviously we used the same cluster url for both. We now want to see staging traffic hitting staging pickup.
Also cleans out some unused old cluster vars.
License: MIT
Signed-off-by: Oli Evans oli@protocol.ai