Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handler for GET /pins?cids=baf1,...,bafN #63

Closed
Tracked by #68
olizilla opened this issue Jan 6, 2023 · 3 comments · Fixed by #67 or #71
Closed
Tracked by #68

Add handler for GET /pins?cids=baf1,...,bafN #63

olizilla opened this issue Jan 6, 2023 · 3 comments · Fixed by #67 or #71
Assignees

Comments

@olizilla
Copy link
Contributor

olizilla commented Jan 6, 2023

we need to handle batch pin status requests where the list of CIDs to check are passed as a comma separated string of cids under the key cids in the URLSearchParams

it's used by the cron-pins scheduled task that runs regularly to poll cluster to see if the pins that were previously Queued are have changed state yet via the cluster client lib cluster.statusAll

@codeflyer codeflyer mentioned this issue Jan 10, 2023
@alanshaw alanshaw mentioned this issue Jan 12, 2023
10 tasks
codeflyer added a commit that referenced this issue Jan 12, 2023
Add handler for GET /pins?cids=baf1,...,bafN

closes #63
@olizilla olizilla reopened this Jan 12, 2023
@olizilla
Copy link
Contributor Author

This is deployed to staging but currently throws an error if more than 1 CID is passed as the cids search param.

@codeflyer
Copy link
Contributor

As discussed, the issue was due a timeout in the lambda.

the deploy was set to a 10 second value. Moved it to 60 seconds to be sure.
The bottleneck is in the cluster, we don't have control on it.

The pickup performance instead are really fast.

@olizilla
Copy link
Contributor Author

@codeflyer the aws http gateway times out after 30s max waiting for a lambda to respond.
https://docs.aws.amazon.com/apigateway/latest/developerguide/limits.html#http-api-quotas

We can probably set the lambda timeout to 31s. the request will have already been closed if it takes longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants