FLEDGE: Pass creative scanning metadata to scoreAd #50341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(This required disabling the optimization of not sending it to the worklet if sendCreativeScanningMetadata is off, since it's now passed to the JS in that case). See WICG/turtledove#792 (comment) for more context. Bug: 383513677 Change-Id: I7b40f47c102a0e9d8160ab33cb9e4eb7553ab02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6190108 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Orr Bernstein <orrb@google.com> Cr-Commit-Position: refs/heads/main@{#1412359}
wpt-pr-bot
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This required disabling the optimization of not sending it to the
worklet if sendCreativeScanningMetadata is off, since it's now passed to
the JS in that case).
See
WICG/turtledove#792 (comment)
for more context.
Bug: 383513677
Change-Id: I7b40f47c102a0e9d8160ab33cb9e4eb7553ab02a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6190108
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Orr Bernstein <orrb@google.com>
Cr-Commit-Position: refs/heads/main@{#1412359}