-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable additional encoding tests in ShadowRealms #49286
base: master
Are you sure you want to change the base?
Enable additional encoding tests in ShadowRealms #49286
Conversation
@@ -1,6 +1,6 @@ | |||
// META: timeout=long | |||
// META: title=Encoding API: Fatal flag for single byte encodings | |||
// META: timeout=long |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might look odd at first glance. META: timeout=long
was listed twice.
Overall LGTM - and very welcome! I especially appreciate modernizing older tests to be .any.js. A couple things:
Apologies for the delay in providing feedback. |
Thanks for the review!
This is a good question. It does need to be a module specifier, so I believe at least
|
When there's multiple files of the same name, such as with |
The TextDecoder test can run in other scopes, because TextDecoder is exposed everywhere.
This test can be run in multiple scopes.
This is an alternative that doesn't require using MessageChannel, which is not exposed everywhere.
These seem to have been missed in web-platform-tests#41968. Includes ensuring that exports from any support files are defined on the global object, and that support scripts are referred to with their absolute paths from the root.
990184d
to
231112f
Compare
Follow-up to #41968. Enables the rest of the TextEncoder, TextDecoder, TextEncoderStream, and TextDecoderStream test coverage inside ShadowRealm scopes.