[document picture-in-picture] Propagate user activation to the opener #45621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24b13dc to
3effef3
Compare
c1e70cc to
3dcb34d
Compare
669b701 to
116bf97
Compare
This CL changes browser-process-side user activation logic to allow activations in document picture-in-picture windows to be used in their opener windows, and activations in the opener windows to be used in their document picture-in-picture windows. This feature is behind an enabled-by-default feature flag. Specification change: WICG/document-picture-in-picture#117 Chromestatus: https://chromestatus.com/feature/5185710702460928 Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ Bug: 331246719 Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393891 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1304599}
116bf97 to
60c3ac9
Compare
wpt-pr-bot
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL changes browser-process-side user activation logic to allow
activations in document picture-in-picture windows to be used in their
opener windows, and activations in the opener windows to be used in
their document picture-in-picture windows.
This feature is behind an enabled-by-default feature flag.
Specification change:
WICG/document-picture-in-picture#117
Chromestatus: https://chromestatus.com/feature/5185710702460928
Intent to Prototype:
https://groups.google.com/a/chromium.org/g/blink-dev/c/MwH0ODG4bec
Intent to Ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/AfzrMoCgccQ
Bug: 331246719
Change-Id: Iedad1e0cb60e04fc1ccf350405f04a399a2b72a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393891
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304599}