[scroll-animations] The animation shorthand should set timeline to auto #37385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 7, 2022
2dcd58a to
61a32c7
Compare
We currently allow the timeline to be specified as part of the animation shorthand. This is (for now) incorrect per a recent CSSWG resolution [1]. This CL changes all WPTs to use the animation-timeline longhand instead. I've also added a setup assertion (or equivalent) to many tests to prevent UAs without support for animation-timeline from running the animations on the document timeline (which could lead to unstable/timing-dependent failure results). [1] w3c/csswg-drafts#6946 (comment) Fixed: 1397870 Change-Id: I97cd13481ea00a074f50c132562d9bb83e7bc4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4084846 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1082380}
61a32c7 to
77f7acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently allow the timeline to be specified as part of the
animation shorthand. This is (for now) incorrect per a recent
CSSWG resolution [1].
This CL changes all WPTs to use the animation-timeline longhand
instead. I've also added a setup assertion (or equivalent) to many
tests to prevent UAs without support for animation-timeline from
running the animations on the document timeline (which could lead
to unstable/timing-dependent failure results).
[1] w3c/csswg-drafts#6946 (comment)
Fixed: 1397870
Change-Id: I97cd13481ea00a074f50c132562d9bb83e7bc4dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4084846
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1082380}