HTML: self.reportError() #29738
Merged
HTML: self.reportError() #29738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcb5b6 to
8e5a434
Compare
3 tasks
domenic
reviewed
Jul 22, 2021
|
I'd rather not touch cross-origin until we have more clarity on whatwg/html#958. |
domenic
approved these changes
Jul 23, 2021
annevk
added a commit
to whatwg/html
that referenced
this pull request
Jul 27, 2021
This allows libraries to emulate the behavior of an exception thrown in an event listener callback. Additional context: whatwg/console#50. Tests: web-platform-tests/wpt#29738. Co-authored-by: Domenic Denicola <d@domenic.me>
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Aug 30, 2021
https://bugs.webkit.org/show_bug.cgi?id=228316 <rdar://problem/81446162> Reviewed by Sam Weinig. LayoutTests/imported/w3c: Import test coverage from: - web-platform-tests/wpt#29738 * web-platform-tests/html/webappapis/scripting/reporterror.any-expected.txt: Added. * web-platform-tests/html/webappapis/scripting/reporterror.any.html: Added. * web-platform-tests/html/webappapis/scripting/reporterror.any.js: Added. (undefined.forEach.throwable.test.t.assert_equals): (test): * web-platform-tests/html/webappapis/scripting/reporterror.any.worker-expected.txt: Added. * web-platform-tests/html/webappapis/scripting/reporterror.any.worker.html: Added. * web-platform-tests/html/webappapis/scripting/w3c-import.log: Added. Source/WebCore: Implement self.reportError() as per: - whatwg/html#1196 Firefox already shipped this and Chrome will do so soon too. Tests: imported/w3c/web-platform-tests/html/webappapis/scripting/reporterror.any.html imported/w3c/web-platform-tests/html/webappapis/scripting/reporterror.any.worker.html * page/DOMWindow.cpp: (WebCore::DOMWindow::reportError): * page/DOMWindow.h: * page/WindowOrWorkerGlobalScope.idl: * workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::reportError): * workers/WorkerGlobalScope.h: Canonical link: https://commits.webkit.org/241098@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
bertogg
pushed a commit
to Igalia/webkit
that referenced
this pull request
Sep 6, 2021
https://bugs.webkit.org/show_bug.cgi?id=228316 <rdar://problem/81446162> Reviewed by Sam Weinig. LayoutTests/imported/w3c: Import test coverage from: - web-platform-tests/wpt#29738 * web-platform-tests/html/webappapis/scripting/reporterror.any-expected.txt: Added. * web-platform-tests/html/webappapis/scripting/reporterror.any.html: Added. * web-platform-tests/html/webappapis/scripting/reporterror.any.js: Added. (undefined.forEach.throwable.test.t.assert_equals): (test): * web-platform-tests/html/webappapis/scripting/reporterror.any.worker-expected.txt: Added. * web-platform-tests/html/webappapis/scripting/reporterror.any.worker.html: Added. * web-platform-tests/html/webappapis/scripting/w3c-import.log: Added. Source/WebCore: Implement self.reportError() as per: - whatwg/html#1196 Firefox already shipped this and Chrome will do so soon too. Tests: imported/w3c/web-platform-tests/html/webappapis/scripting/reporterror.any.html imported/w3c/web-platform-tests/html/webappapis/scripting/reporterror.any.worker.html * page/DOMWindow.cpp: (WebCore::DOMWindow::reportError): * page/DOMWindow.h: * page/WindowOrWorkerGlobalScope.idl: * workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::reportError): * workers/WorkerGlobalScope.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@281756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
mfreed7
pushed a commit
to mfreed7/html
that referenced
this pull request
Jun 3, 2022
This allows libraries to emulate the behavior of an exception thrown in an event listener callback. Additional context: whatwg/console#50. Tests: web-platform-tests/wpt#29738. Co-authored-by: Domenic Denicola <d@domenic.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.