[Import Maps] Make null entries be ignored instead of causing errors
#21050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 6, 2020
This CL makes `null` entries, i.e. mappings to `null`, `[]`, invalid URLs, etc., be ignored, while previously they caused an error. Built-in-modules-enabled cases: The tests for built-in-modules-enabled cases are based on an old version of the spec where `null` entries should cause errors. This CL changes the tests so that `null` entries are ignored. Associated spec updates for this change is not needed for now, because the built-in modules support is tentatively dropped from the spec. Built-in-modules-disabled cases: The new behavior is already conformant with the current spec and WPT tests. Bug: 990561, WICG/import-maps#184 Change-Id: I3ce416adc9b9145b7fae8d9a22973698bd632f7e
fa9cb38 to
85df83b
Compare
|
Close this PR because the Chromium CL cannot be found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL makes
nullentries, i.e. mappings tonull,[], invalid URLs,etc., be ignored, while previously they caused an error.
Built-in-modules-enabled cases:
The tests for built-in-modules-enabled cases are based on an old version
of the spec where
nullentries should cause errors.This CL changes the tests so that
nullentries are ignored.Associated spec updates for this change is not needed for now,
because the built-in modules support is tentatively dropped from the spec.
Built-in-modules-disabled cases:
The new behavior is already conformant with the current spec and WPT tests.
Bug: 990561, WICG/import-maps#184
Change-Id: I3ce416adc9b9145b7fae8d9a22973698bd632f7e
Reviewed-on: https://chromium-review.googlesource.com/1986653
WPT-Export-Revision: 16d4743f1a586050f5f2828672412b1dc1577d63