-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for URL issue 348 #11389
Add test for URL issue 348 #11389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing tests too! This looks good to me, but I'll let @domenic verify per usual.
Decided to land this anyway given that @achristensen07 did all the work required and it's a trivial enough change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't quite right.
"input": "notspecial://host/?'", | ||
"base": "about:blank", | ||
"href": "notspecial://host/?'", | ||
"origin": "notspecial://host", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
origin should be "null"
Sigh, I should learn to wait. |
I'll post a fix. |
No description provided.