-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add invoketarget logic for popovers in button DefaultEventHandler
This adds logic on how buttons with an invoketarget pointing to an element with `popover` should behave, based on the Invokers proposal. See explainer section here: https://open-ui.org/components/invokers.explainer/#defaults. See related spec PR here: whatwg/html#9875 This introduces new behavior just within the HTML Form Control `DefaultEventHandler` function such that: - If an `invoketarget` points to an element with `popover` - If the `invokeaction` is `auto` or `togglePopover`, try to toggle the popover - If the `invokeaction` is `hidePopover`, try to hide the popover - If the `invokeaction` is `showPopover`, try to show the popover If the `invokeaction` is none of the above, then it will fall through the to `HandleInvokeInternal` which is passed the lowercased atom so element subclasses can handle their individual behaviors. Bug: 1494737 Change-Id: Id2ab6faf8782a0fe0ba5c9f05ff562fee640f8b0
- Loading branch information
1 parent
00f51f3
commit 9a5fd3f
Showing
1 changed file
with
193 additions
and
0 deletions.
There are no files selected for viewing
193 changes: 193 additions & 0 deletions
193
html/semantics/invokers/invoketarget-on-popover-behavior.tentative.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,193 @@ | ||
| <!doctype html> | ||
| <meta charset="utf-8" /> | ||
| <meta name="author" title="Keith Cirkel" href="mailto:keithamus@github.com" /> | ||
| <link rel="help" href="https://open-ui.org/components/invokers.explainer/" /> | ||
| <script src="/resources/testharness.js"></script> | ||
| <script src="/resources/testharnessreport.js"></script> | ||
| <script src="/resources/testdriver.js"></script> | ||
| <script src="/resources/testdriver-actions.js"></script> | ||
| <script src="/resources/testdriver-vendor.js"></script> | ||
| <script src="resources/invoker-utils.js"></script> | ||
|
|
||
| <div id="invokee" popover> | ||
| <button id="invokerbutton2" invoketarget="invokee"></button> | ||
| </div> | ||
| <button id="invokerbutton" invoketarget="invokee"></button> | ||
|
|
||
| <script> | ||
| // auto | ||
|
|
||
| promise_test(async function (t) { | ||
| assert_false(invokee.matches(":popover-open")); | ||
| await clickOn(invokerbutton); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| }, "invoking (as auto) closed popover opens"); | ||
|
|
||
| promise_test(async function (t) { | ||
| assert_false(invokee.matches(":popover-open")); | ||
| invokee.addEventListener("invoke", (e) => e.preventDefault(), { | ||
| once: true, | ||
| }); | ||
| await clickOn(invokerbutton); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| assert_false(invokee.matches(":popover-open")); | ||
| }, "invoking (as auto) closed popover with preventDefault does not open"); | ||
|
|
||
| promise_test(async function (t) { | ||
| invokee.showPopover(); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| await clickOn(invokerbutton2); | ||
| assert_false(invokee.matches(":popover-open")); | ||
| }, "invoking (as auto) open popover closes"); | ||
|
|
||
| promise_test(async function (t) { | ||
| invokee.showPopover(); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| invokee.addEventListener("invoke", (e) => e.preventDefault(), { | ||
| once: true, | ||
| }); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| await clickOn(invokerbutton2); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| }, "invoking (as auto) open popover with preventDefault does not close"); | ||
|
|
||
| // togglepopover | ||
|
|
||
| promise_test(async function (t) { | ||
| assert_false(invokee.matches(":popover-open")); | ||
| invokerbutton.setAttribute("invokeaction", "togglepopover"); | ||
| t.add_cleanup(() => invokerbutton.removeAttribute("invokeaction")); | ||
| await clickOn(invokerbutton); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| }, "invoking (as togglepopover) closed popover opens"); | ||
|
|
||
| promise_test(async function (t) { | ||
| assert_false(invokee.matches(":popover-open")); | ||
| invokerbutton.setAttribute("invokeaction", "tOgGlEpOpOvEr"); | ||
| t.add_cleanup(() => invokerbutton.removeAttribute("invokeaction")); | ||
| await clickOn(invokerbutton); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| }, "invoking (as togglepopover - case insensitive) closed popover opens"); | ||
|
|
||
| promise_test(async function (t) { | ||
| assert_false(invokee.matches(":popover-open")); | ||
| invokerbutton.setAttribute("invokeaction", "togglepopover"); | ||
| t.add_cleanup(() => invokerbutton.removeAttribute("invokeaction")); | ||
| invokee.addEventListener("invoke", (e) => e.preventDefault(), { | ||
| once: true, | ||
| }); | ||
| await clickOn(invokerbutton); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| assert_false(invokee.matches(":popover-open")); | ||
| }, "invoking (as togglepopover) closed popover with preventDefault does not open"); | ||
|
|
||
| promise_test(async function (t) { | ||
| invokee.showPopover(); | ||
| invokerbutton2.setAttribute("invokeaction", "togglepopover"); | ||
| t.add_cleanup(() => invokerbutton2.removeAttribute("invokeaction")); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| await clickOn(invokerbutton2); | ||
| assert_false(invokee.matches(":popover-open")); | ||
| }, "invoking (as togglepopover) open popover closes"); | ||
|
|
||
| promise_test(async function (t) { | ||
| invokee.showPopover(); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| invokerbutton2.setAttribute("invokeaction", "togglepopover"); | ||
| t.add_cleanup(() => invokerbutton2.removeAttribute("invokeaction")); | ||
| invokee.addEventListener("invoke", (e) => e.preventDefault(), { | ||
| once: true, | ||
| }); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| await clickOn(invokerbutton2); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| }, "invoking (as togglepopover) open popover with preventDefault does not close"); | ||
|
|
||
| // showpopover | ||
|
|
||
| promise_test(async function (t) { | ||
| invokerbutton.setAttribute("invokeaction", "showpopover"); | ||
| t.add_cleanup(() => invokerbutton.removeAttribute("invokeaction")); | ||
| assert_false(invokee.matches(":popover-open")); | ||
| await clickOn(invokerbutton); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| }, "invoking (as showpopover) closed popover opens"); | ||
|
|
||
| promise_test(async function (t) { | ||
| invokerbutton.setAttribute("invokeaction", "sHoWpOpOvEr"); | ||
| t.add_cleanup(() => invokerbutton.removeAttribute("invokeaction")); | ||
| assert_false(invokee.matches(":popover-open")); | ||
| await clickOn(invokerbutton); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| }, "invoking (as showpopover - case insensitive) closed popover opens"); | ||
|
|
||
| promise_test(async function (t) { | ||
| invokerbutton.setAttribute("invokeaction", "showpopover"); | ||
| t.add_cleanup(() => invokerbutton.removeAttribute("invokeaction")); | ||
| invokee.showPopover(); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| await clickOn(invokerbutton); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| }, "invoking (as showpopover) open popover is noop"); | ||
|
|
||
| promise_test(async function (t) { | ||
| invokerbutton.setAttribute("invokeaction", "showpopover"); | ||
| t.add_cleanup(() => invokerbutton.removeAttribute("invokeaction")); | ||
| assert_false(invokee.matches(":popover-open")); | ||
| invokee.addEventListener("invoke", (e) => e.preventDefault(), { | ||
| once: true, | ||
| }); | ||
| await clickOn(invokerbutton); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| assert_false(invokee.matches(":popover-open")); | ||
| }, "invoking (as showpopover) closed popover with preventDefault does not open"); | ||
|
|
||
| // hidepopover | ||
|
|
||
| promise_test(async function (t) { | ||
| invokerbutton.setAttribute("invokeaction", "hidepopover"); | ||
| t.add_cleanup(() => invokerbutton.removeAttribute("invokeaction")); | ||
| assert_false(invokee.matches(":popover-open")); | ||
| await clickOn(invokerbutton); | ||
| assert_false(invokee.matches(":popover-open")); | ||
| }, "invoking (as hidepopover) closed popover is noop"); | ||
|
|
||
| promise_test(async function (t) { | ||
| invokerbutton2.setAttribute("invokeaction", "hidepopover"); | ||
| t.add_cleanup(() => invokerbutton2.removeAttribute("invokeaction")); | ||
| invokee.showPopover(); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| await clickOn(invokerbutton2); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| assert_false(invokee.matches(":popover-open")); | ||
| }, "invoking (as hidepopover) open popover closes"); | ||
|
|
||
| promise_test(async function (t) { | ||
| invokerbutton2.setAttribute("invokeaction", "hIdEpOpOvEr"); | ||
| t.add_cleanup(() => invokerbutton2.removeAttribute("invokeaction")); | ||
| invokee.showPopover(); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| await clickOn(invokerbutton2); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| assert_false(invokee.matches(":popover-open")); | ||
| }, "invoking (as hidepopover - case insensitive) open popover closes"); | ||
|
|
||
| promise_test(async function (t) { | ||
| invokerbutton2.setAttribute("invokeaction", "hidepopover"); | ||
| t.add_cleanup(() => invokerbutton2.removeAttribute("invokeaction")); | ||
| invokee.showPopover(); | ||
| t.add_cleanup(() => invokee.hidePopover()); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| invokee.addEventListener("invoke", (e) => e.preventDefault(), { | ||
| once: true, | ||
| }); | ||
| await clickOn(invokerbutton2); | ||
| assert_true(invokee.matches(":popover-open")); | ||
| }, "invoking (as hidepopover) open popover with preventDefault does not close"); | ||
| </script> |