Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reduce memory consumption of paths #8581

Merged
merged 1 commit into from
Dec 2, 2024
Merged

perf: reduce memory consumption of paths #8581

merged 1 commit into from
Dec 2, 2024

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Nov 29, 2024

Summary

Reduced a big amount of memory of copying PathBufs.

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Nov 29, 2024
Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit c8e202b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/674d9a8fd233b70008f1192c
😎 Deploy Preview https://deploy-preview-8581--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented Dec 2, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Dec 2, 2024

📝 Benchmark detail: Open

Name Base (2024-12-02 5a967f7) Current Change
10000_big_production-mode_disable-minimize + exec 42.8 s ± 1.97 s 42.6 s ± 535 ms -0.34 %
10000_development-mode + exec 1.8 s ± 45 ms 1.82 s ± 29 ms +1.25 %
10000_development-mode_hmr + exec 648 ms ± 5.5 ms 649 ms ± 8 ms +0.13 %
10000_production-mode + exec 2.39 s ± 30 ms 2.4 s ± 48 ms +0.23 %
arco-pro_development-mode + exec 1.73 s ± 82 ms 1.78 s ± 91 ms +2.44 %
arco-pro_development-mode_hmr + exec 426 ms ± 2.5 ms 426 ms ± 1.1 ms +0.09 %
arco-pro_production-mode + exec 3.13 s ± 60 ms 3.11 s ± 70 ms -0.41 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.16 s ± 77 ms 3.19 s ± 38 ms +1.07 %
threejs_development-mode_10x + exec 1.62 s ± 15 ms 1.63 s ± 17 ms +0.15 %
threejs_development-mode_10x_hmr + exec 810 ms ± 8.1 ms 810 ms ± 20 ms +0.05 %
threejs_production-mode_10x + exec 4.94 s ± 37 ms 4.92 s ± 30 ms -0.36 %
10000_big_production-mode_disable-minimize + rss memory 13399 MiB ± 459 MiB 13334 MiB ± 127 MiB -0.49 %
10000_development-mode + rss memory 775 MiB ± 13.2 MiB 777 MiB ± 28.7 MiB +0.32 %
10000_development-mode_hmr + rss memory 2010 MiB ± 398 MiB 2119 MiB ± 237 MiB +5.44 %
10000_production-mode + rss memory 671 MiB ± 27.6 MiB 659 MiB ± 24.1 MiB -1.69 %
arco-pro_development-mode + rss memory 741 MiB ± 47.6 MiB 725 MiB ± 43.6 MiB -2.13 %
arco-pro_development-mode_hmr + rss memory 922 MiB ± 152 MiB 938 MiB ± 89.4 MiB +1.70 %
arco-pro_production-mode + rss memory 878 MiB ± 26.9 MiB 871 MiB ± 50.3 MiB -0.84 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 871 MiB ± 38.5 MiB 861 MiB ± 51.6 MiB -1.18 %
threejs_development-mode_10x + rss memory 830 MiB ± 31.6 MiB 812 MiB ± 53.8 MiB -2.13 %
threejs_development-mode_10x_hmr + rss memory 2115 MiB ± 194 MiB 2132 MiB ± 210 MiB +0.77 %
threejs_production-mode_10x + rss memory 1037 MiB ± 68.4 MiB 1052 MiB ± 31.7 MiB +1.40 %

@h-a-n-a h-a-n-a changed the title perf: init perf: reduce memory consumption of paths Dec 2, 2024

Verified

This commit was signed with the committer’s verified signature.
h-a-n-a Hana
@h-a-n-a h-a-n-a marked this pull request as ready for review December 2, 2024 11:58
@h-a-n-a h-a-n-a requested a review from jerrykingxyz as a code owner December 2, 2024 11:58
@h-a-n-a h-a-n-a enabled auto-merge (squash) December 2, 2024 11:58
@h-a-n-a h-a-n-a merged commit 0de6669 into main Dec 2, 2024
33 checks passed
@h-a-n-a h-a-n-a deleted the use-arc-path branch December 2, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants