Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: align webpack DefinePlugin for destructuring optimization #8452

Merged
merged 1 commit into from
Nov 18, 2024
Merged

feat: align webpack DefinePlugin for destructuring optimization #8452

merged 1 commit into from
Nov 18, 2024

Conversation

inottn
Copy link
Collaborator

@inottn inottn commented Nov 15, 2024

Summary

close #8120

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Nov 15, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 8a2eb84
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/673776bc69ac74000802985d

@chenjiahan chenjiahan requested a review from h-a-n-a November 16, 2024 07:25
h-a-n-a
h-a-n-a approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@h-a-n-a h-a-n-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@h-a-n-a h-a-n-a merged commit e379fe9 into web-infra-dev:main Nov 18, 2024
34 checks passed
@inottn inottn deleted the feat/define branch November 18, 2024 07:07
@h-a-n-a h-a-n-a mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Align webpack DefinePlugin for destructuring optimization
2 participants
@inottn @h-a-n-a