Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use eprintln to report error for runtime_requirements #4717

Merged
merged 1 commit into from
Nov 21, 2023
Merged

chore: use eprintln to report error for runtime_requirements #4717

merged 1 commit into from
Nov 21, 2023

Conversation

JSerFeng
Copy link
Contributor

Summary

use eprintln to report error for runtime_requirements

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@JSerFeng
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Nov 20, 2023
Merged
Merged
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 20, 2023
@JSerFeng JSerFeng marked this pull request as ready for review November 20, 2023 12:03
ahabhgk
ahabhgk previously approved these changes Nov 20, 2023
View reviewed changes
@JSerFeng
Copy link
Contributor Author

JSerFeng commented Nov 20, 2023 •
edited
Loading

Merge activity

  • Nov 20, 7:55 AM: @JSerFeng started a stack merge that includes this pull request via Graphite.
  • Nov 20, 7:55 AM: Graphite failed to merge this pull request due to This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite. Try your merge again, or report a bug if you see this consistently.

Base automatically changed from 11-20-chore_chunk_graph_improve_chunk_graph_perf to main November 20, 2023 13:07
@JSerFeng JSerFeng dismissed ahabhgk’s stale review November 20, 2023 13:07

The base branch was changed.

@JSerFeng JSerFeng enabled auto-merge November 20, 2023 13:15
@JSerFeng JSerFeng requested a review from ahabhgk November 20, 2023 13:15
@JSerFeng JSerFeng force-pushed the 11-20-chore_use_eprintln_to_report_error_for_runtime_requirements branch from d02f4ef to 0205602 Compare November 20, 2023 13:41
@JSerFeng JSerFeng added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit aa6d758 Nov 21, 2023
14 of 24 checks passed
@JSerFeng JSerFeng deleted the 11-20-chore_use_eprintln_to_report_error_for_runtime_requirements branch November 21, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy

Assignees

@JSerFeng JSerFeng

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSerFeng @ahabhgk