Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support WarnCaseSensitiveModulesPlugin #4379

Merged
merged 9 commits into from
Nov 6, 2023
Merged

feat: support WarnCaseSensitiveModulesPlugin #4379

merged 9 commits into from
Nov 6, 2023

Conversation

OceanPresentChao
Copy link
Contributor

Summary

issue: 4347

This Plugin warns when there are case sensitive modules in the compilation

Test Plan

run test in webpack-test/errors/case-sensitive

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@OceanPresentChao OceanPresentChao requested review from a team October 21, 2023 08:33
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Oct 21, 2023
@ahabhgk
Copy link
Contributor

ahabhgk commented Oct 22, 2023

Snapshot needs update, you can run pnpm run test -- -u under packages/rspack to update them

@ahabhgk ahabhgk linked an issue Oct 23, 2023 that may be closed by this pull request
feat: support WarnCaseSensitiveModulesPlugin #4347
Closed
@OceanPresentChao
Copy link
Contributor Author

Snapshot needs update, you can run pnpm run test -- -u under packages/rspack to update them

Could you take a review? Thanks

@ahabhgk
Copy link
Contributor

ahabhgk commented Nov 2, 2023

Sorry for the delay, will take a look tomorrow

ahabhgk
ahabhgk requested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great, it's a right solution, but still need to make some little changes

crates/rspack_plugin_warn_sensitive_module/src/lib.rs Outdated Show resolved Hide resolved
crates/rspack_plugin_warn_sensitive_module/src/lib.rs Outdated Show resolved Hide resolved
crates/rspack_ids/src/lib.rs Outdated Show resolved Hide resolved
packages/rspack/tests/hotCases/warnings/case-sensitive/index.js Outdated Show resolved Hide resolved
webpack-test/cases/errors/case-sensitive/warnings.js Outdated Show resolved Hide resolved
ahabhgk
ahabhgk previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ahabhgk ahabhgk added this pull request to the merge queue Nov 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2023
@ahabhgk ahabhgk enabled auto-merge November 6, 2023 10:03
auto-merge was automatically disabled November 6, 2023 11:50

Head branch was pushed to by a user without write access

@ahabhgk ahabhgk enabled auto-merge November 6, 2023 11:58
@ahabhgk ahabhgk added this pull request to the merge queue Nov 6, 2023
Merged via the queue into web-infra-dev:main with commit b32da51 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@hyf0 hyf0 Awaiting requested review from hyf0

@Boshen Boshen Awaiting requested review from Boshen

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy

@hardfist hardfist Awaiting requested review from hardfist

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: support WarnCaseSensitiveModulesPlugin
2 participants
@OceanPresentChao @ahabhgk