Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mjs file node mode interop #2296

Merged
merged 4 commits into from
Mar 16, 2023
Merged

fix: mjs file node mode interop #2296

merged 4 commits into from
Mar 16, 2023

Conversation

underfin
Copy link
Contributor

@underfin underfin commented Mar 16, 2023 •
edited by h-a-n-a
Loading

Summary

  • fix: node mode interop

Related issue (if exists)

fixes #2190
related nodejs/node#40891

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 7fd8cf6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@rspack/binding Patch
@rspack/core Patch
@rspack/postcss-loader Patch
@rspack/cli Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/dev-client Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@underfin underfin force-pushed the node-mode-interop branch from 1afa844 to 10a5ca3 Compare March 16, 2023 08:19
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 16, 2023
@underfin underfin changed the title fix: node mode interop fix: mjs file node mode interop Mar 16, 2023
jerrykingxyz
jerrykingxyz previously approved these changes Mar 16, 2023
View reviewed changes
h-a-n-a
h-a-n-a previously approved these changes Mar 16, 2023
View reviewed changes
@h-a-n-a h-a-n-a dismissed their stale review March 16, 2023 11:36

Mistaken

h-a-n-a
h-a-n-a previously approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@h-a-n-a h-a-n-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@h-a-n-a h-a-n-a dismissed stale reviews from jerrykingxyz and themself via 597b8b5 March 16, 2023 11:38
h-a-n-a
h-a-n-a previously approved these changes Mar 16, 2023
View reviewed changes
@h-a-n-a h-a-n-a force-pushed the node-mode-interop branch from 597b8b5 to 7fd8cf6 Compare March 16, 2023 12:33
@h-a-n-a h-a-n-a merged commit 7fde34f into main Mar 16, 2023
@h-a-n-a h-a-n-a deleted the node-mode-interop branch March 16, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

@jerrykingxyz jerrykingxyz jerrykingxyz left review comments

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report]: JS evaluation fails when importing from three.js
3 participants
@underfin @jerrykingxyz @h-a-n-a