feat: support Comment for Document #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 116f171 The changes in this PR will be included in the next version bump. This PR includes changesets to release 211 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3496 +/- ##
==========================================
+ Coverage 57.59% 57.87% +0.27%
==========================================
Files 672 653 -19
Lines 17794 17188 -606
Branches 3876 3749 -127
==========================================
- Hits 10249 9948 -301
+ Misses 6934 6641 -293
+ Partials 611 599 -12
... and 125 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
yimingjfe
approved these changes
Apr 19, 2023
chenjiahan
reviewed
Apr 20, 2023
| @@ -49,6 +49,8 @@ import { Html, Body, Root, Head, Scripts } from '@modern-js/runtime/document'; | |||
|
|
|||
| - `Scripts`：构建产生的 script 内容，可用于调整构建产物的位置，默认放在 `<Head>` 组件中。 | |||
|
|
|||
| - `Comment`：将用户编写的 `<!-- gateway -->` 这种注释，保留输出到最新渲染的 html 中。 | |||
There was a problem hiding this comment.
We should add english document too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support Comment component in Document.tsx file which could be stay the user's comment in the finall html.
🤖 Generated by Copilot at 77e4d47
This pull request adds a new feature to the plugin-runtime that allows inserting and decoding comments in the HTML output. It introduces a new
Commentcomponent that renders comments as encoded placeholders, and a new CLI option that decodes them. It also updates the integration tests to cover this feature.Details
🤖 Generated by Copilot at 77e4d47
Commentcomponent to render encoded HTML comments in the document head or body (link, link, link, link)document/constants.tsfile to define and access the encoded comment placeholders (link, link)renderHtmlfunction in thedocument/cli/index.tsfile to decode and replace the encoded comments in the HTML output (link)tests/integration/app-document/tests/index.test.jsfile to verify the comment rendering feature (link)tests/integration/app-document/tests/index.test.jsfile (link, link)Related Issue
#3495
Checklist
pnpm run change.