-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): the esm format files should be generate for the client #3427
Conversation
🦋 Changeset detectedLatest commit: 79f8594 The changes in this PR will be included in the next version bump. This PR includes changesets to release 213 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ab0bba7
to
a5d5399
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3427 +/- ##
==========================================
+ Coverage 57.59% 57.96% +0.36%
==========================================
Files 672 668 -4
Lines 17794 17732 -62
Branches 3876 3858 -18
==========================================
+ Hits 10249 10278 +29
+ Misses 6934 6847 -87
+ Partials 611 607 -4
... and 76 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Summary
On the client side, we need to use the code in esm format.
🤖 Generated by Copilot at 1bb1196
This pull request improves the build and export configuration of the
@modern-js/utils
and@modern-js/server
packages to support different module formats and TypeScript types.Details
🤖 Generated by Copilot at 1bb1196
hmr-client
module in the@modern-js/server
package, which enables hot module replacement for the client-side code (link)getHMRClientPath
function in the@modern-js/server
package to use the new export entry for thehmr-client
module instead of the relative path (link)modern.config.js
file in the@modern-js/utils
package to use an array of build configurations for different output formats and targets, and to copy thecompiled
folder from the source to the output directory (link)exports
property, and thetypesVersions
property in thepackage.json
file of the@modern-js/utils
package to point to the appropriate format and type declaration files in thedist
subfolders, and to fix a JSON syntax error (link, link, link, link, link, link, link, link)Related Issue
Checklist
pnpm run change
.