Throw TypeErrors on invalid inputs to AnimationEffectTiming #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,12 +76,18 @@ | |||
| return this._fill; | |||
| }, | |||
| set iterationStart(value) { | |||
| if (value < 0) { | |||
There was a problem hiding this comment.
Should this have an isNan check as well, like duration?
There was a problem hiding this comment.
Added check, I realise now the NaN check is implicit in the IDL type.
| for (var i = 0; i <= 1; i += 0.1) { | ||
| assert.equal(f(i), i, easing + ' is linear'); | ||
| } | ||
| function assertThrows(easing) { |
There was a problem hiding this comment.
To make this test easier to read, I think this function name should be more explicit about what it does. This is a bit long but maybe something like assertThrowsOnConversionToTimingFunction? assertInvalidEasingThrows?
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds TypeErrors to setters on AnimationEffectTiming for
iterationStart,iterations,durationandeasing.Relevant spec: http://w3c.github.io/web-animations/#animationeffecttiming