Don't store Javascript functions on AnimationEffectTiming.easing or keyframe.easing #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed that updating the Google IO 2016 site to use this version of the polyfill no longer hits the TypeError in a build of Chrome that TypeErrors on invalid easings. |
|
lgtm |
alancutter
added a commit
to alancutter/web-animations-codelabs
that referenced
this pull request
Oct 18, 2016
Update web-animations-js version to include the [fix for TypeErrors when using groups](web-animations/web-animations-next#423).
alancutter
added a commit
to alancutter/web-animations-codelabs
that referenced
this pull request
Oct 18, 2016
Update web-animations-js version to include the [fix for TypeErrors when using groups](web-animations/web-animations-next#423).
alancutter
added a commit
to alancutter/web-animations-codelabs
that referenced
this pull request
Oct 18, 2016
Update web-animations-js version to include the [fix for TypeErrors when using groups](web-animations/web-animations-next#423).
alancutter
added a commit
to alancutter/web-animations-codelabs
that referenced
this pull request
Oct 18, 2016
Update web-animations-js version to include the [fix for TypeErrors when using groups](web-animations/web-animations-next#423).
alancutter
added a commit
to alancutter/web-animations-codelabs
that referenced
this pull request
Oct 18, 2016
Update web-animations-js version to include the [fix for TypeErrors when using groups](web-animations/web-animations-next#423).
alancutter
added a commit
to alancutter/web-animations-codelabs
that referenced
this pull request
Oct 18, 2016
Update web-animations-js version to include the [fix for TypeErrors when using groups](web-animations/web-animations-next#423).
alancutter
added a commit
to alancutter/web-animations-codelabs
that referenced
this pull request
Oct 18, 2016
Update web-animations-js version to include the [fix for TypeErrors when using groups](web-animations/web-animations-next#423).
alancutter
added a commit
to alancutter/web-animations-codelabs
that referenced
this pull request
Oct 18, 2016
Update web-animations-js version to include the [fix for TypeErrors when using groups](web-animations/web-animations-next#423).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are places in the code where we use AnimationEffectTiming as input to KeyframeEffect, it should conform to the specified interface where easing is a string.
http://w3c.github.io/web-animations/#the-animationeffecttiming-interface
This change is a pre-fix for when toTimingFunction() will throw a TypeError on invalid easing input and break most of our group tests.