Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch undefined for leftArgs[0] and rightArgs[0] #118

Closed
wants to merge 1 commit into from

Conversation

karlhaas
Copy link

@karlhaas karlhaas commented Apr 4, 2017

Fix for #115

@karlhaas karlhaas changed the title catch undefined for leftArgs[0] and ightArgs[0]) catch undefined for leftArgs[0] and rightArgs[0] Apr 4, 2017
@alancutter
Copy link
Contributor

Thanks for writing up this fix for us!
Before we can accept your submission we require you sign the Contributor License Agreement. Sorry for the hassle.

I think it might be better to change

to return null instead for consistency with itself.
It should also be relatively simple to add a test for this bug as well in https://github.com/web-animations/web-animations-js/blob/5f3d17fbb60dd82a3775f0c7fd7667f787096deb/test/js/transform-handler.js by giving it something like matrix(0, 0, 0, 0, 0, 0) as one of the keyframe inputs.

@karlhaas
Copy link
Author

karlhaas commented Apr 7, 2017

It says "It looks like you've already signed this CLA". I'm not really familiar with the source and just fixed the problem I found by debugging the source (it would have been easier if there would have been a non minified version of the bundle ;) )
Maybe someone who knows the code base better should provide further improvements.

@alancutter
Copy link
Contributor

Maybe someone who knows the code base better should provide further improvements.

Landed a fix in #121, thanks again for doing the initial investigation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants