Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add swift-format support #34

Merged
merged 6 commits into from
May 2, 2020
Merged

Add swift-format support #34

merged 6 commits into from
May 2, 2020

Conversation

compnerd
Copy link
Contributor

@compnerd compnerd commented Apr 6, 2020

Fixes #33

@samuelmeuli samuelmeuli added the enhancement New feature or request label Apr 10, 2020
samuelmeuli
samuelmeuli requested changes Apr 10, 2020
View reviewed changes
Copy link
Collaborator

@samuelmeuli samuelmeuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @compnerd, thanks a lot for the PR! :)

.github/workflows/test.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
src/linters/index.js Outdated Show resolved Hide resolved
test/linters/params/swift-format.js Outdated Show resolved Hide resolved
samuelmeuli
samuelmeuli requested changes Apr 10, 2020
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@compnerd
Copy link
Contributor Author

Sorry about the delay, this is still on my list of things to get done, just have been busy.

@compnerd compnerd force-pushed the swift-format branch 7 times, most recently from 5ea1ff8 to 87210c8 Compare April 29, 2020 20:48
@compnerd compnerd force-pushed the swift-format branch 2 times, most recently from 40e1b19 to e5e3ad6 Compare April 29, 2020 22:43
@compnerd
CI: switch to using Linux for testing
b596a9e 
As the GitHub virtual environment now has the swift toolchain, use
that to build swift-lint and run the tests.
@compnerd compnerd requested a review from samuelmeuli April 29, 2020 23:41
@compnerd
Copy link
Contributor Author

I eventually just opted to switch the testing to Linux as it was simpler. Sorry about this taking so long.

@samuelmeuli
Copy link
Collaborator

Thanks for updating the code! And nice solution with the tests 👍🏻

@samuelmeuli samuelmeuli merged commit c6935ca into wearerequired:master May 2, 2020
@samuelmeuli
Copy link
Collaborator

Merged – thanks again, @compnerd!

@compnerd
Copy link
Contributor Author

compnerd commented May 2, 2020

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samuelmeuli samuelmeuli samuelmeuli approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add swift-format support
2 participants
@compnerd @samuelmeuli