wip: support previously registered U2F factors as WebAuthN factors. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okta transitioned all of our u2f factors to webauthn. This change does the bare minimum to support them, but probably does not properly support true webauthn factors.
Xeroday
reviewed
Nov 15, 2019
| authData := make([]byte, 37) | ||
| rpid := sha256.Sum256([]byte(c.domain)) | ||
| copy(authData[0:32], rpid[0:32]) | ||
| authData[32] = 0x80 |
There was a problem hiding this comment.
When logging into Okta through a browser, this is set to 0x05, which sets the user verified and user present flags.
alsmola
reviewed
Dec 6, 2019
| timeoutSeconds := 30 | ||
| ctx, _ := context.WithTimeout(context.Background(), time.Second*time.Duration(timeoutSeconds)) | ||
|
|
||
| authResp, err := c.prompts.VerifyU2F(ctx, VerifyU2FRequest{ |
There was a problem hiding this comment.
Where is VerifyU2FRequest implemented? I'm trying to get webauthn with Okta to work in Go with code very similar to segmentio/aws-okta#201 using https://github.com/marshallbrekka/go-u2fhost under the hood. I'm getting a "The provided key handle is not present on the device, or was created with a different application parameter" error.
If you have a Go implementation of U2F that works with the new Okta webauthn factors, I'd love to know about it!
fheydrich
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okta transitioned all of our u2f factors to webauthn. This change does the bare
minimum to support them, but probably does not properly support true webauthn
factors.