Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint errors #160

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix: lint errors #160

merged 1 commit into from
Feb 8, 2022

Conversation

razbakov
Copy link
Contributor

@razbakov razbakov commented Feb 8, 2022 •
edited
Loading

Changes

  • eslint: fixed 45 problems (21 errors, 24 warnings), see below
  • now lint is part of build. Build will fail if there are any lint errors.

How to test

  • Checkout branch locally
  • Introduce an error in the file (i.e. formatting or add unused variable in code)
  • Run yarn build
  • It should fail if there are lint errors

Screenshot 2022-02-08 at 13 58 45

@razbakov razbakov requested a review from amanuela97 February 8, 2022 12:53
@razbakov razbakov self-assigned this Feb 8, 2022
@razbakov razbakov changed the title chore: fix lint errors fixЖ lint errors Feb 8, 2022
@razbakov razbakov changed the title fixЖ lint errors fix: lint errors Feb 8, 2022
@razbakov razbakov added bug Something isn't working chore A tedious but necessary task labels Feb 8, 2022
@razbakov razbakov merged commit 990658d into beta Feb 8, 2022
@razbakov razbakov deleted the build-eslint branch February 8, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelson2411 nelson2411 nelson2411 approved these changes

@amanuela97 amanuela97 Awaiting requested review from amanuela97

@larrycoal larrycoal Awaiting requested review from larrycoal

@booleanrecep booleanrecep Awaiting requested review from booleanrecep

@harshbrahmxatriya harshbrahmxatriya Awaiting requested review from harshbrahmxatriya

@Stefanacef Stefanacef Awaiting requested review from Stefanacef

Assignees

@razbakov razbakov

Labels
bug Something isn't working chore A tedious but necessary task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razbakov @nelson2411