Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: auth #147

Merged
merged 5 commits into from
Feb 8, 2022
Merged

i18n: auth #147

merged 5 commits into from
Feb 8, 2022

Conversation

Stefanacef
Copy link
Contributor

@Stefanacef Stefanacef commented Feb 3, 2022 •
edited
Loading

closes #73

How to test it:

https://wedance-stefanacef.netlify.app/

  • Test the pop-up: Log out from your account, and search for a dancer's name and on the bottom you will see the watch button and star button and the three dots on the left, push on them, and the pop-up will appear
    image
  • The no password page: go on no password page, write your email and press the button and a pop up will appear

@amanuela97
i18n: Settings (#114)
c3721e0 
* fix: translation for /settings

* fix: tips, before, label grouped by fieldName

* fix: changes made to translation for settings page

* fix: restructured translation keys

* fix: date keys capitalized

* fix: Capitalize saturday and sunday
razbakov
razbakov requested changes Feb 3, 2022
View reviewed changes
locales/en.yml Outdated Show resolved Hide resolved
@Stefanacef Stefanacef requested a review from razbakov February 4, 2022 12:39
razbakov
razbakov requested changes Feb 5, 2022
View reviewed changes
locales/en.yml Outdated Show resolved Hide resolved
locales/en.yml Outdated Show resolved Hide resolved
locales/en.yml Outdated Show resolved Hide resolved
@razbakov razbakov added the i18n Internationalization label Feb 5, 2022
@razbakov razbakov changed the title i18n: Auth i18n: auth Feb 5, 2022
nelson2411
nelson2411 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@nelson2411 nelson2411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done! 👨‍💻

@Stefanacef Stefanacef merged commit b69a950 into beta Feb 8, 2022
@Stefanacef Stefanacef deleted the auth-translation branch February 8, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelson2411 nelson2411 nelson2411 approved these changes

@razbakov razbakov razbakov approved these changes

@amanuela97 amanuela97 Awaiting requested review from amanuela97

@booleanrecep booleanrecep Awaiting requested review from booleanrecep

@harshbrahmxatriya harshbrahmxatriya Awaiting requested review from harshbrahmxatriya

Assignees

@Stefanacef Stefanacef

Labels
i18n Internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Stefanacef @razbakov @smaft @nelson2411 @booleanrecep @amanuela97 @larrycoal