i18n: post editor #77 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razbakov
requested changes
Feb 1, 2022
There was a problem hiding this comment.
-
No need to close old PR, just push new commits to that branch and your PR will get updated.
-
PR Title should give a clear summary and answer “why this change was made” no “what was changed”. All pull request titles will be listed in the release notes and users with non-technical background should understand what was changed or what was fixed.
-
PR Title should have a prefix:
“i18n: ” if you added internationalisation strings
* fix: translation for /settings * fix: tips, before, label grouped by fieldName * fix: changes made to translation for settings page * fix: restructured translation keys * fix: date keys capitalized * fix: Capitalize saturday and sunday
resolve conflict
razbakov
requested changes
Feb 2, 2022
razbakov
requested changes
Feb 2, 2022
razbakov
requested changes
Feb 2, 2022
razbakov
requested changes
Feb 3, 2022
razbakov
requested changes
Feb 3, 2022
…m into feature/Post_Editor_#77 i18n
|
@larrycoal congrats with your first contribution! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test it ?
Go to edit post
localised the pages there
https://wedance-larry.netlify.app/