hw #6

Miguelwoluba · 2017-09-27T04:34:41Z

Miguel Mejia

BritneyJo · 2017-09-27T19:29:53Z

index.html

@@ -25,7 +25,7 @@ <h1 class="title">Weather App</h1>

          <h2 class="results-city"></h2>

-
+           <div class=iconPic></div>


Try to stick with consistent naming conventions. All other class names are written with a hyphen so this should follow that pattern and be "icon-pic".

BritneyJo · 2017-09-27T19:30:35Z

js/main.js

+    var city= $(".weather-city").val();
+
+
+$.ajax({


Watch your indents!

BritneyJo · 2017-09-27T19:31:38Z

js/main.js

+
+
+$(document).ready(function() {
+  $('.btn-primary').on('click', requestWeatherData);


Instead of having to add a class to you can select this specific input, you could also do a form submit event listener.

Miguelwoluba added 2 commits September 26, 2017 23:33

hw

dccef90

hW readme

f176e32

BritneyJo reviewed Sep 27, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hw #6

hw #6

Miguelwoluba commented Sep 27, 2017

BritneyJo Sep 27, 2017

BritneyJo Sep 27, 2017

BritneyJo Sep 27, 2017

		@@ -25,7 +25,7 @@ <h1 class="title">Weather App</h1>

		<h2 class="results-city"></h2>


		<div class=iconPic></div>



		$(document).ready(function() {
		$('.btn-primary').on('click', requestWeatherData);

hw #6

Are you sure you want to change the base?

hw #6

Conversation

Miguelwoluba commented Sep 27, 2017

BritneyJo Sep 27, 2017

Choose a reason for hiding this comment

BritneyJo Sep 27, 2017

Choose a reason for hiding this comment

BritneyJo Sep 27, 2017

Choose a reason for hiding this comment