weather-app update #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BritneyJo
reviewed
Sep 27, 2017
| <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"> | ||
| <link rel="stylesheet" href="css/style.css"> |
| var toF; | ||
| var thisMap; | ||
|
|
||
| $('.weather-app').css('background-color', 'rgba(255,255,255,.5)'); |
There was a problem hiding this comment.
I'd prefer you set this in the CSS and not use js to add custom styles.
| //Initialized description | ||
| $('.description').append("<strong>Condition Outside:</strong> "); | ||
|
|
||
| $('.submission').click(function(event){ |
| $('.flag-icon').empty(); | ||
| $('.city-error').css('display', 'none'); | ||
|
|
||
| var toF = parseInt(((((weatherData.main.temp)-273.15)*1.8)+32)); |
There was a problem hiding this comment.
Instead of doing all the math, you could have also used the API which requires another parameter to be sent as data in your ajax call 'units=imperial'. Since you are serializing your form to get the data automatically, you could have added another hidden input for this <input type="hidden" name="units" value="imperial">.
| var toF = parseInt(((((weatherData.main.temp)-273.15)*1.8)+32)); | ||
| console.dir(toF); | ||
| $('.results-city').append(weatherData.name + ", " + weatherData.sys.country); | ||
| $('.temperature').append(toF + '°'); |
There was a problem hiding this comment.
You'll want to look up the character code for the degree symbol. While it may work in some browsers, it will also break in a lot more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.